Make annotations on expect declarations comply with new compiler restriction #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merfemor
added
the
kotlin-merge-blocker
qwwdfsad
requested changes
Jul 19, 2023
merfemor
force-pushed
the
roman.efremov/MR/expect-annotations
branch
from
3c0e4d1 to
45f749d
Compare
merfemor
force-pushed
the
roman.efremov/MR/expect-annotations
branch
from
45f749d to
90542df
Compare
qwwdfsad
reviewed
Jul 21, 2023
kotlinx-coroutines-core/common/src/internal/StackTraceRecovery.common.kt
Outdated
Show resolved
Hide resolved
…riction In KT-58551 we require all annotations from expect declaration to be present on actual. This commit fixes the following violations: 1. `DefaultDelay` has `@PublishedApi` only on expect, thus it must be copied to all actuals. 2. `unwrap` has the same problem. 3. expect `IgnoreJreRequirement` has `AnnotationTarget.TYPE` which is not present in actual. This is because Java target TYPE doesn't correspond to Kotlin target TYPE. Since `IgnoreJreRequirement` is internal, we can safely change targets on expect and make them equal to actual.
merfemor
force-pushed
the
roman.efremov/MR/expect-annotations
branch
from
7e25e7e to
3c9e856
Compare
mshishkina
approved these changes
Jul 21, 2023
qwwdfsad
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In KT-58551 we require all annotations from expect declaration to be present on actual.
This commit fixes the following violations:
DefaultDelayhas@PublishedApionly on expect. But it is not used from public inline functions, so we can safely remove annotation.expect
IgnoreJreRequirementhasAnnotationTarget.TYPEwhich is not present in actual. This is because Java target TYPE doesn't correspond to Kotlin target TYPE. SinceIgnoreJreRequirementis internal, we can safely change targets on expect and make them equal to actual.